Skip to content

Sonobi - Analytics Adapter#3615

Merged
idettman merged 4 commits intoprebid:masterfrom
sonobi:sonobi-analytics
Mar 18, 2019
Merged

Sonobi - Analytics Adapter#3615
idettman merged 4 commits intoprebid:masterfrom
sonobi:sonobi-analytics

Conversation

@ghost
Copy link

@ghost ghost commented Mar 5, 2019

Type of change

  • Other
    New Analytics Adapter

Description of change

Added an analytics Adapter for sonobi

pbjs.enableAnalytics({
                  provider: 'sonobi',
                     options: {
                  	     pubId: 'ffBB352',
                         siteId: 57463,
                         delay: 300
                     }
                })

idettman
idettman approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer more tests, but it covers the events so LGTM

@idettman idettman merged commit 4fd7c47 into prebid:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@idettman idettman

Labels

adapter support LGTM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@idettman @edahood-sonobi @jongo593

Comments