ReklamStore Bid Adapter#3634
Merged
jaiminpanchal27 merged 3 commits intoprebid:masterfrom Mar 26, 2019
Merged
Conversation
ReklamStore Bid Adapter
Contributor
|
Docs PR at prebid/prebid.github.io#1205 |
jaiminpanchal27
requested changes
Mar 20, 2019
Collaborator
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
There was a problem hiding this comment.
@ReklamStoreIT Left some comments
modules/reklamstoreBidAdapter.js
Outdated
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| aliases: ['reklamstore'], |
Collaborator
There was a problem hiding this comment.
No need to add aliases if you are repeating bidder_code here. aliases are to be used if you want to use some short code for bidder in adUnit config.
modules/reklamstoreBidAdapter.js
Outdated
| */ | ||
| buildRequests: function (validBidRequests) { | ||
| let requests = []; | ||
| let loc = utils.getTopWindowLocation(); |
Collaborator
There was a problem hiding this comment.
Use http://prebid.org/dev-docs/bidder-adaptor.html#referrers
utils.getTopWindowLocation(); is a deprecated function and will be removed soon
modules/reklamstoreBidAdapter.js
Outdated
| } | ||
| }, | ||
| /** | ||
| * Register the user sync pixels which should be dropped after the auction. |
Collaborator
There was a problem hiding this comment.
Please fix spacing in all the jsdoc
modules/reklamstoreBidAdapter.js
Outdated
| registerBidder(spec); | ||
|
|
||
| function getDeviceType() { | ||
| var PHONE = 0; |
Collaborator
There was a problem hiding this comment.
Use let/const in place of var
| import { expect } from 'chai'; | ||
| import { spec } from 'modules/reklamstoreBidAdapter'; | ||
|
|
||
| describe('reklamstoreBidAdapterTests', function() { |
Collaborator
There was a problem hiding this comment.
Add unit test for user sync
Added unit test for user sync
Update bid adapter
Contributor
Author
|
Changes are done. |
jaiminpanchal27
approved these changes
Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReklamStore Bid Adapter
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information