Skip to content

ADman Media new bidder adapter#3639

Merged
idettman merged 4 commits intoprebid:masterfrom
admanmedia:master
Mar 22, 2019
Merged

ADman Media new bidder adapter#3639
idettman merged 4 commits intoprebid:masterfrom
admanmedia:master

Conversation

@admanmedia
Copy link
Contributor

  • New bidder adapter

  • test parameters for validating bids

{
  bidder: 'adman',
  params: {
    id: 5ae1b797
  }
}

@bretg
Copy link
Contributor

bretg commented Mar 18, 2019

Docs PR at prebid/prebid.github.io#1209

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log

@idettman
Copy link
Contributor

All changes look good, however I see there is a console.log used in the test file, this needs to be removed. Once this is completed, I'll approve

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit e604ab3 into prebid:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments