Improve Digital adapter: use Prebid sizes param#3648
Merged
harpere merged 14 commits intoprebid:masterfrom Mar 25, 2019
Merged
Conversation
harpere
reviewed
Mar 19, 2019
| if (localSize && localSize.w && localSize.h) { | ||
|
|
||
| if (config.getConfig('improvedigital.usePrebidSizes') === true && bid.sizes && bid.sizes.length > 0) { | ||
| normalizedBidRequest.format = bid.sizes; |
Collaborator
There was a problem hiding this comment.
I don't think sizes is normally included in the bid request object. Is this some special case? or is this supposed to be the bid response?
Contributor
Author
There was a problem hiding this comment.
It's supposed to be in the bid request, not response. Here's I believe where sizes field is populated: https://github.com/prebid/Prebid.js/blob/master/src/adapterManager.js#L98
Also, Appnexus adapter uses sizes the same way: https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L463
Collaborator
There was a problem hiding this comment.
Cool, I wasn't aware of that. thx for the pointers.
harpere
approved these changes
Mar 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New adapter config parameter "usePrebidSizes" added which tells the Improve Digital ad server to serve the creatives based on the sizes defined in Prebid ad unit config rather than placement sizes defined in the ad server.
Related doc PR: prebid/prebid.github.io#1211