Rubicon Bid Adapter: custom price granularity fix#3670
Merged
robertrmartinez merged 14 commits intoprebid:masterfrom Mar 26, 2019
Merged
Rubicon Bid Adapter: custom price granularity fix#3670robertrmartinez merged 14 commits intoprebid:masterfrom
robertrmartinez merged 14 commits intoprebid:masterfrom
Conversation
…ebid.js into master-rubicon-clean
# Conflicts: # modules/advangelistsBidAdapter.js # test/spec/modules/advangelistsBidAdapter_spec.js
…ter-remote-updated
…stomPriceBucket from customPriceGranularity
idettman
changed the title
robertrmartinez
approved these changes
Mar 25, 2019
Collaborator
robertrmartinez
left a comment
robertrmartinez
left a comment
There was a problem hiding this comment.
I have tested this and it LGTM
Sorry I did not catch this before :(
harpere
reviewed
Mar 26, 2019
harpere
reviewed
Mar 26, 2019
modules/rubiconBidAdapter.js
Outdated
| {min: 3.00, max: 8.00, increment: 0.05}, | ||
| {min: 8.00, max: 20.00, increment: 0.50} | ||
| ], | ||
| custom: config.getConfig('priceGranularity') === 'custom' ? config.getConfig('customPriceBucket').buckets : undefined |
Collaborator
There was a problem hiding this comment.
there's no need for the ternary operator because the custom param will only be chosen when config.getConfig('priceGranularity') === 'custom'
updating per review
Collaborator
|
Example PBS Requests in browser: With custom granularity: With high granularity: |
harpere
approved these changes
Mar 26, 2019
Collaborator
|
MERGING! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
In the Rubicon Bid Adapter, a config property used in
getPriceGranularity(), was renamed fromcustomPriceGranularitytocustomPriceBucket.Added a test to verify all granularity values return the expected results.