remove removeRequestId logic when getting bids#3698
Merged
Conversation
jaiminpanchal27
approved these changes
Apr 2, 2019
jaiminpanchal27
added
the
needs 2nd review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #3685
This PR removes the logic we had in place to remove the
requestIdfield from the bid objects that were returned in the public API's variousgetBids...type functions.Context
Originally introduced in #1970, the
requestId's value for a long time was equal to the bid'sadId; so it was unnecessary to have both included when one was just used internally.However when #3440 was introduced, the
requestIdandadIdheld different responsibilities (see linked PR for details).At this point, both fields should be present when we're getting the bids from an auction.