Skip to content

ShowHeroes Adapter#3733

Merged
jaiminpanchal27 merged 1 commit intoprebid:masterfrom
showheroes:master
Apr 19, 2019
Merged

ShowHeroes Adapter#3733
jaiminpanchal27 merged 1 commit intoprebid:masterfrom
showheroes:master

Conversation

@vadim-mazzherin
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: "showheroes-bs",
  params: {
     playerId: '0151f985-fb1a-4f37-bb26-cfc62e43ec05',
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadim-mazzherin Code is LGTM. Just one question, i tried the banner bidder params shared by you on our hello_world page and in bid response your endpoint sent vastTag for banner. Is it correct ?

@vadim-mazzherin
Copy link
Contributor Author

@jaiminpanchal27 Yes, it is correct

@jaiminpanchal27 jaiminpanchal27 merged commit 12eceea into prebid:master Apr 19, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments