Update supported sizes in adapter bid response#3738
Merged
mike-chowla merged 6 commits intoprebid:masterfrom Apr 20, 2019
Merged
Update supported sizes in adapter bid response#3738mike-chowla merged 6 commits intoprebid:masterfrom
mike-chowla merged 6 commits intoprebid:masterfrom
Conversation
- Default size returned changed from 0x0 to 1x1 to support PrebidServer - Now will always respect the bid sizes supported when configured Co-authored-by: Josh Becker <jbecker@sharethrough.com>
Update supported sizes
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Add HTML5 video support param to bid requests * Use const instead of var for consistency * Update supported sizes - Default size returned changed from 0x0 to 1x1 to support PrebidServer - Now will always respect the bid sizes supported when configured Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Update maintainer contact email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Change default size returned from 0x0 to 1x1 to support Prebid Server
Use bid request sizes in building bid response when
sizeConfigis setpubgrowth.engineering@sharethrough.com