addressed feedback from #3731 ticket#3752
Conversation
|
@EMXDigital Thanks for putting the changes together and recreating this PR. I'll take a look over the updates soon and follow-up. |
|
docs PR prebid/prebid.github.io#1252 |
jsnellbaker
left a comment
jsnellbaker
left a comment
There was a problem hiding this comment.
Hi @EMXDigital these changes look good; just had a question with some of the unit tests.
Can you take a look and update as necessary? We should be good to merge after this last item.
| // const testBid = Object.assign({}, bid); | ||
| // delete testBid.mediaTypes.video.playerSize; | ||
| // expect(spec.isBidRequestValid(testBid)).to.equal(false); | ||
| // }) |
There was a problem hiding this comment.
Are these tests something you want to reactivate? Or remove?
There was a problem hiding this comment.
Thanks, we've removed these lines in our latest commit.
| }); | ||
| }); | ||
|
|
||
| // describe('emxAdapter helper validity', function () { |
There was a problem hiding this comment.
Same here; should these tests stay or go?
There was a problem hiding this comment.
We've removed these lines.
|
@EMXDigital Thanks for making the extra updates; LGTM |
* addressed feedback from prebid#3731 ticket * removed commented code from emx test spec * logging removed from spec * flip h & w values from playerSize for video requests
3 participants
Type of change
Description of change
Adding Instream mediatype to EMX Digital. New PR from accidental closed PR [here]. This includes all requested updates to our adapter from that ticket. (#3731).