Debug Unit Test Issue in CircleCI #3754
Merged
idettman merged 4 commits intoprebid:masterfrom Apr 26, 2019
Merged
Conversation
idettman
added
needs review
performance
and removed
build process
troubleshooting
labels
Contributor
Author
|
Updated tests to address test instability after the userid module was merged. I removed any use of prebid global methods in tests, and I also changed tests to be async (with calls to done on complete) |
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* add skip to last test * change skip to describe block * updated tests to be more stable by removing prebid global calls in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Do not review yet. Debugging issues occurring in circleci stemming from userid unit test/s.