Conversation
aprakash-sovrn
force-pushed
the
sovrn-analytics
branch
from
05850cd to
7aefe99
Compare
jsnellbaker
left a comment
jsnellbaker
left a comment
There was a problem hiding this comment.
Can you please take a look at the change request below?
Additionally, can you please put together a docs PR (here)[https://github.com/prebid/prebid.github.io/pulls] to add your analytics adapter to the list? It should be at least this page that needs an update: https://github.com/prebid/prebid.github.io/blob/master/overview/analytics.md
modules/sovrnAnalyticsAdapter.js
Outdated
| import CONSTANTS from 'src/constants.json' | ||
| import {ajaxBuilder} from 'src/ajax' | ||
| import * as utils from 'src/utils' | ||
| import {config} from 'src/config' |
There was a problem hiding this comment.
In lieu of this PR #3435, any imported files within a modules file needs to use the relative style path.
Can you please update these imports accordingly?
There was a problem hiding this comment.
sure thing. does this apply to npm modules as well?
There was a problem hiding this comment.
No it should just be needed for any Prebid imports.
|
Created doc PR: prebid/prebid.github.io#1282 |
* Sovrn Analytics Adapter * unit test fix * use relative paths for imports
3 participants
Type of change
Description of change
Sovrn Analytics Adapter