Conversation
|
I've requested a partner id for testing by emailing contact@id5.io We're going to need to update the doc on prebid.org, but that can wait until after inspection |
There was a problem hiding this comment.
Everything looks great, with one small change: On line 214, rename GDPRApplies to ...
|
|
@padurgeat - FYI, we're going to be re-factoring the UserId module this week to be more modular. When that's complete, we'd ask that you refactor this Pull Request to fit into the changes. Will post again when the refactoring is complete. |
|
I'm not really surprised, let me know :) |
|
@bretg Any news here ? cheers |
|
@padurgeat - yes. The refactoring PR has been merged. Please refactor your code to be a 'sub-module' with the name |
# Conflicts: # modules/userId.js # test/spec/modules/userId_spec.js
|
@bretg Refactoring done. Let me know if any other change is required. Thanks |
|
Hey guys, should I push a PR for website documentation, or should we wait to have a least on adapter passing the ID5 id before ? cheers, |
|
@padurgeat Yes, pIease push a PR for website documentation, thanks |
idettman
left a comment
idettman
left a comment
There was a problem hiding this comment.
Check my comment for small change request to move the submodule registration out of userId.js and into id5System.js
|
@padurgeat there’s a circle CI error from duplicates imports, once that’s fixed I’ll approve. Change to: |
|
@idettman done! |
|
This is ready to be merged as soon as a docs link is ready |
|
@idettman docs PR is here: prebid/prebid.github.io#1363 |
* Extract GDPRApplies in userId.js to make it available to cookie-sync requiring it * Adding id5 userId submodule, tests and documentation * Fixed typo in test name for unifiedid * Adding test to userId for ID5 * Follow correct naming convention for GDPRApplies: renamed to isGDPRApplicable * Refactoring of id5 module following refactoring of userId module. * Moved init of id5 user module at the end of the id5 module itself * regroup import to avoid a CircleCI Bug
* Extract GDPRApplies in userId.js to make it available to cookie-sync requiring it * Adding id5 userId submodule, tests and documentation * Fixed typo in test name for unifiedid * Adding test to userId for ID5 * Follow correct naming convention for GDPRApplies: renamed to isGDPRApplicable * Refactoring of id5 module following refactoring of userId module. * Moved init of id5 user module at the end of the id5 module itself * regroup import to avoid a CircleCI Bug
4 participants
Type of change
Description of change
This PR add a id5 submodule in userId to fetch ID5 user id and add it to the bid request. It is mostly a duplicate of unifiedId code and tests.
Maintainer
padurgeat@id5.io