Fix #3813 move auctionEnd events so it always executes when auction completes#3841
Merged
jsnellbaker merged 2 commits intomasterfrom Jun 18, 2019
Merged
Fix #3813 move auctionEnd events so it always executes when auction completes#3841jsnellbaker merged 2 commits intomasterfrom
jsnellbaker merged 2 commits intomasterfrom
Conversation
jsnellbaker
added
needs review
needs 2nd review
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
jaiminpanchal27
approved these changes
Jun 5, 2019
robertrmartinez
approved these changes
Jun 18, 2019
Collaborator
robertrmartinez
left a comment
robertrmartinez
left a comment
There was a problem hiding this comment.
Looks good. Thanks @jsnellbaker
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
…tion completes (prebid#3841) * move auctionEnd events so it always executes * remove some commented code
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
…tion completes (prebid#3841) * move auctionEnd events so it always executes * remove some commented code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #3813.
This change was made primarily to ensure that the auctionEnd event will always trigger even if the publisher didn't include a
bidsBackHandlerwhen making thepbjs.requestBids()call (as found while looking into the above issue).This change also ensures other actions taken after the auction finishes are always executed (such as calling timed out bidders, firing userSyncs, and changing the auctionStatus).