Adding Scaleable Analytics Adapter#3846
Conversation
|
Current failing tests are unrelated to my code |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@mike-chowla Just checking in on an update with this as it has been 3 weeks and it is now marked as stale. |
|
@jaiminpanchal27 @jsnellbaker Is there anyone else that can help me out with this and get it approved, it's been three weeks and I haven't heard a thing while noticing other adapters have been approved and merged already when the PRs were created after mine. Thank You, |
|
@cconnors1515 I'll take a look at this PR today and follow-up; apologies for the delay. |
jsnellbaker
requested review from
jsnellbaker
and removed request for
mike-chowla
jsnellbaker
left a comment
jsnellbaker
left a comment
There was a problem hiding this comment.
I looked through the adapter code and it appears to be good. In terms of testing, I tried to load a basic page with the adapter. However, I saw a series of 400 errors from the analytics endpoint as the auction events triggered.
I'm assuming it's due to the test value I entered for the site param in the analytics adapter config. Is there a test site I can use to verify the adapter? Thanks.
|
@jsnellbaker Thank you for taking the time to look at this! I removed the commented code from the spec file and you can test with site param of : 5c4fab7a829e955d6c265e72 |
|
@cconnors1515 Thanks for the update and the test site. Everything worked fine when I tested again. |
|
@jsnellbaker Thanks for all your help! Are you able to merge my sibling PR for the docs as well or does bretg have to do that? |
* Adding Scaleable Analytics Adapter * Removed commented out code
* Adding Scaleable Analytics Adapter * Removed commented out code
3 participants
Type of change
Description of change
Adding Scaleable Analytics Adapter
Other
Sibling PR: prebid/prebid.github.io#1322