Added bid adapter for seedtag#3915
Added bid adapter for seedtag#3915jaiminpanchal27 merged 3 commits intoprebid:masterfrom seedtag:master
Conversation
sumit116
left a comment
There was a problem hiding this comment.
Hi @cabama,
Thanks for submitting your adaptor. You need to pass vastUrl in the bid object in your adaptor file like this vastUrl: rtbBid.rtb.video.asset_url. vastUrl is a mandatory field for instream videos. Please refer appnexusBidAdapter.js for more info.
|
From what we have seen in the response documentation our understanding was that vastUrl is not mandatory if the vastXml field is returned. Is this still the case or is vastUrl required? |
|
It seems like |
sumit116
left a comment
There was a problem hiding this comment.
Tested the adaptor on hello_world page and all unit tests have passed. Test coverage of the adaptor is 80%. The changes are working well against all parameters listed in https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md, hence approving the PR.
* Added bid adapter for seedtag * Revert changes to package-lock * added safe check
* Added bid adapter for seedtag * Revert changes to package-lock * added safe check
Type of change
Description of change
Adding new bid adapter for seedtag
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Link to docs PR
Other information