Closed
Conversation
jaiminpanchal27
requested review from
idettman,
jsnellbaker,
mkendall07 and
snapwich
Merged
1 task
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fix for #3908
Recently many use cases have come across where we needed submodules for prebid. Example include
Also in future we would like to add other features as modules and not part of core.
Until we have a new build system and fresh approach to modules this PR fixes #3908.
This fix returns the modules which are included in module.json or as command line arguments to gulp.src.
Command 1:
gulp build --modules=appnexusBidAdapter,digiTrustIdSystem --analyzeResult
Command 1:
gulp build --analyzeResult