Conversation
…ebid.js into master-rubicon-clean
# Conflicts: # modules/advangelistsBidAdapter.js # test/spec/modules/advangelistsBidAdapter_spec.js
…ter-remote-updated
jsnellbaker
left a comment
There was a problem hiding this comment.
@msm0504 These changes look good from my perspective.
Could you add a (or some) unit test(s) to the new utils function?
Thanks!
|
@jsnellbaker I've added unit tests for the |
jsnellbaker
left a comment
There was a problem hiding this comment.
@msm0504 I think that test run was just a fluke. It's passing now on the subsequent test run.
LGTM
robertrmartinez
left a comment
There was a problem hiding this comment.
Nice!
Love the new deepSetValue util being added. Thanks!
|
Docs PR prebid/prebid.github.io#1367 |
|
@robertrmartinez Thank @idettman. He wrote the util. I copied it for my PR. Also, I'm going to post in the slack channel about using a library for these types of utils. I asked about |
* Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * Send coppa flag on requests to OpenRTB from Prebid server * Support coppa flag being set in Prebid config * Add unit tests for deepSetValue util function
* Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * Send coppa flag on requests to OpenRTB from Prebid server * Support coppa flag being set in Prebid config * Add unit tests for deepSetValue util function
Type of change
Description of change
Support coppa flag being set in Prebid config and then sent to OpenRTB and individual adapter APIs
#3852
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information