Multiple sizes handling in adYouLike adaptor#4013
Merged
harpere merged 11 commits intoprebid:masterfrom Aug 11, 2019
Merged
Conversation
bretg
suggested changes
Jul 22, 2019
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
This doesn't appear to be looking in AdUnit.mediaType.sizes -- if it's not, please update to look in that location as well as AdUnit.sizes, which has been deprecated for a long time.
Contributor
Author
|
Changes have been made regarding the use of bid.mediatype.banner.sizes |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
Why is this Pull request in stale state ? thank you. |
harpere
approved these changes
Aug 11, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* Remove useless bidderCode in bid response * send all the available sizes in the bid request * Use the banner sizes if given * avoid compatibility issue with old bid format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add multiple sizes handling in adYouLike bidder adaptor.
contact email of the adapter’s maintainer
guillaume.andouard@adyoulike.com
[* ] official adapter submission