Fix referrer encoding in The Media Grid Bid Adapter#4040
Merged
msm0504 merged 15 commits intoprebid:masterfrom Jul 30, 2019
TheMediaGrid:master
Merged
Fix referrer encoding in The Media Grid Bid Adapter#4040msm0504 merged 15 commits intoprebid:masterfrom TheMediaGrid:master
msm0504 merged 15 commits intoprebid:masterfrom
TheMediaGrid:master
Conversation
…u' parameter in ad request
Contributor
Author
|
@jsnellbaker Hey guys, this is actually a hotfix for #3968 and it is currently a blocker from getting the correct referer. Any chances you could push that to release ASAP? We have a couple of publishers ready to go live pending this. Thanks in advance. |
Collaborator
|
@TheMediaGrid Unfortunately, this would have to wait until the next release. We do releases every Tuesday; as this is currently merged, this update will definitely be part of the upcoming 2.27.0 release scheduled for Aug 6. CC: @mkendall07 |
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Added Grid Bid Adapter * remove priceType from TheMediaGrid Bid Adapter * Add video support in Grid Bid Adapter * Added test parameter for video slot * update Grid Bid Adapter to set size in response bid * Update Grid Bid Adapter to support identical uids in parameters * Fix typo in test file for Grid Bid Adapter * Update The Grid Media Bidder Adapter to send refererInfo.referer as 'u' parameter in ad request * Hotfix for referrer in Grid Bid Adapter
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* Added Grid Bid Adapter * remove priceType from TheMediaGrid Bid Adapter * Add video support in Grid Bid Adapter * Added test parameter for video slot * update Grid Bid Adapter to set size in response bid * Update Grid Bid Adapter to support identical uids in parameters * Fix typo in test file for Grid Bid Adapter * Update The Grid Media Bidder Adapter to send refererInfo.referer as 'u' parameter in ad request * Hotfix for referrer in Grid Bid Adapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Stopped using encodeURIComponent where it is not necessary, to avoid double encoded string in referrer.
Other information
This fix for PR #3968