Adding support of Instream/Outstream Video for the SmileWanted Adapter#4064
Merged
Fawke merged 1 commit intoprebid:masterfrom Aug 9, 2019
MaxSmileWanted:master
Merged
Adding support of Instream/Outstream Video for the SmileWanted Adapter#4064Fawke merged 1 commit intoprebid:masterfrom MaxSmileWanted:master
Fawke merged 1 commit intoprebid:masterfrom
MaxSmileWanted:master
Conversation
Contributor
|
@MaxSmileWanted Hey, sorry for the delay in response. This PR looks fine, there's one thing you can do though. You can update your docs PR here, update the metadata section of your markdown file to include this key As an example, layout: bidder |
Contributor
Author
|
Hi @Fawke, Oh no worries the time frame is not very long, two days is not much, compared to other projects ;) I create the PR on the doc site : prebid/prebid.github.io#1426 Thanks |
Fawke
approved these changes
Aug 9, 2019
Fawke
pushed a commit
to prebid/prebid.github.io
that referenced
this pull request
Aug 9, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows video support (Instream and Outstream) for the SmileWanted adapter.
Type of change
Description of change
Testing
Video Instream
Video Outstream