update logic of ad_types field in appnexusBidAdapter

[jsnellbaker]

Type of change

• Feature

Description of change

This PR changes how the ad_types field of the appnexus request is populated in relation to banner media type.

Previously the field was populated automatically with 'banner' if the mediaType(s) field of the bid object was empty or if either of those fields were set to banner. The latter case actually always happened since Prebid.js treats any adUnit request without a defined mediaTypes object as banner and creates a mediaTypes field in the bid with a banner object in this scenario.

Now with this change, the banner ad_type is only populated if the original adUnit contained a mediaTypes.banner object. If the adUnit.mediaTypes object is missing, then the field is left out of the appnexus request. In terms of the delivery decision for the bid, this scenario would defer to the types that are setup within the placement and use that to choose the type of bid to find/return.

[mkendall07]

placing on hold for now due to some concerns about multi format.

[mkendall07]

on hold

[jsnellbaker]

@mkendall07 Per the internal feedback, this change should be good to implement. Can you take another look when you have the chance? Thanks!

[mkendall07]

LGTM

[lsv1]

Hey all,

When I define adUnits without mediaTypes I get a parsing error returned, it looks like it's related to missing sizes in the request payload to AppNexus.

I think sizes must still be defined and sent over to avoid the parse error. Check out my Fiddle for a working example - http://jsfiddle.net/nfm0ahbk/2/.