revert karma and other package updates#4067
Merged
jsnellbaker merged 1 commit intomasterfrom Aug 6, 2019
Merged
Conversation
jaiminpanchal27
approved these changes
Aug 6, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This is a partial revert to the karma/webpack-stream package and subsequent node updates introduced by #4038
As part of these updates, there was a requirement to have to use Node 9 (or greater) due to karma's use of the spread operator in its workflow; the spread operator (ie
...args) is only available in Node 9+.The internal build system that we use for the prebid.js releases is not currently up to this version of node and would need some additional time to get it updated. So we're temporarily reverting these updates in the meantime.
The other changes from the original PR (namely the
process.exitcommands in thegulpfile) are left intact since they are needed to help ensure the circleCI complete successfully and are not impacted by the node version.