update to use dlv/index to fix webpack sourcemaps#4071
Merged
jsnellbaker merged 1 commit intomasterfrom Aug 13, 2019
Merged
Conversation
jsnellbaker
approved these changes
Aug 9, 2019
Collaborator
jsnellbaker
left a comment
jsnellbaker
left a comment
There was a problem hiding this comment.
Thanks for digging into and finding this fix!
jsnellbaker
added
the
needs 2nd review
robertrmartinez
approved these changes
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
For whatever reason the
//# sourceMappingURL=dlv.umd.js.mapat the end of the npmdlvmodule breaks the sourcemaps for the main webpack chunk (in which its included). I'm not sure why that is, although it seems to be the only npm include that has its own sourcemaps, so maybe this is a wider issue that we've avoided.Either way, I've updated the code to import
dlv/indexwhich is the unminified code without sourcemaps (and webpack will minify and generate sourcemaps for, which is fine).Other information
Related to #3993