Skip to content

SupplyChain object support in Prebid #4084

Merged
idettman merged 41 commits intoprebid:masterfrom
pm-harshad-mane:small_changes
Aug 30, 2019
Merged

SupplyChain object support in Prebid #4084
idettman merged 41 commits intoprebid:masterfrom
pm-harshad-mane:small_changes

Conversation

@pm-harshad-mane
Copy link
Contributor

Type of change

  • Feature
  • Code style update (formatting, local variables)

Description of change

  • Supply chain object support in Prebid Proposal: Add support for passing SupplyChain Object to all bidders #3870 adapterManager will validate the schain object and will pass it to bidders/adapters only if it is valid, thus bidders/adapters will not require to validate schain object.
  • schain param support in PubMatic adapter
  • other minor changes in PubMatic adapter for better readability
             pbjs.setConfig({
                    "schain": {
                        "ver":"1.0",
                        "complete": 1,
                        "nodes": [
                            {
                                "asi":"indirectseller.com",
                                "sid":"00001",
                                "hp":1
                            }
                        ]     
                    }
                });

@pm-harshad-mane
Copy link
Contributor Author

Hello @jsnellbaker , @bretg
Could you please review the code?

@pm-harshad-mane
Copy link
Contributor Author

Please do not merge these changes as QA is pending.

@pm-harshad-mane
Copy link
Contributor Author

Hello @bretg , @jaiminpanchal27
Can you please help me find why CI job is failing, I checked the logs but I am clueless to find a root-cause.

@pm-harshad-mane
Copy link
Contributor Author

Thanks @jaiminpanchal27 , CI worked 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments