Skip to content

Datablocks bid/analytics adapter#4128

Merged
jsnellbaker merged 10 commits intoprebid:masterfrom
datablocks:master
Sep 6, 2019
Merged

Datablocks bid/analytics adapter#4128
jsnellbaker merged 10 commits intoprebid:masterfrom
datablocks:master

Conversation

@htang555
Copy link
Contributor

Type of change

  • New bidder adapter
  • New Bundle Analytics adapter

Description of change

Adding Datablocks Bidder and Analytics Adapter

  • test parameters for validating bids
{
  bidder: 'datablocks',
  params: {
     host: 'search.nutella.datablocks.net',
     sourceId:906295
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

henry@datablocks.net

@jonapgar
Copy link
Contributor

This passes tests when run locally with --browserstack but we are seeing errors from other bid adapters on circleci.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @htang555

Thanks for putting together these adapters.

Overall the code looks good (see minor note below for a tweak in the one .md file).

While testing the bidAdapter's native support, I received a 400 Bad Request response from the adserver. I used the sample bid params from the PR description with the mediaTypes object taken from the .md file.

I copied the request and response objects below. Can you take a look?

Request

{"id":"8d6ce1a2-a943-49c2-8adc-b42550ff96f3","imp":[{"id":"218cefd050fb1f","tagid":"/19968336/prebid_native_example_1","secure":false,"native":"{\"assets\":[{\"id\":\"title_0\",\"required\":true,\"title\":{\"len\":140}},{\"id\":\"body_1\",\"required\":true,\"data\":{\"type\":2}}]}"}],"site":{"id":"blank","domain":"test.localhost","page":"http://test.localhost/integrationExamples/gpt/undefined"},"device":{"ip":"peer","ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36","js":1,"language":"en"}}

Response

{
  "id": "8d6ce1a2-a943-49c2-8adc-b42550ff96f3",
  "bidid": "179055385-1345-18974-0",
  "seatbid": [],
  "nbr": 2,
  "ext": {
	"error": "Empty RTB Impression Object"
  }
}

The banner test went fine, so just need to figure out the native test.

Thanks!

@htang555
Copy link
Contributor Author

htang555 commented Sep 4, 2019

@jsnellbaker Thanks for the review! I have made the changes to the .md examples you requested as well fixed the native request issue with the bid adapter.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htang555 Thanks for making the updates. The native test is working now.

@jsnellbaker jsnellbaker merged commit f828b84 into prebid:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments