Datablocks bid/analytics adapter#4128
Datablocks bid/analytics adapter#4128jsnellbaker merged 10 commits intoprebid:masterfrom datablocks:master
Conversation
|
This passes tests when run locally with --browserstack but we are seeing errors from other bid adapters on circleci. |
jsnellbaker
left a comment
There was a problem hiding this comment.
Hi @htang555
Thanks for putting together these adapters.
Overall the code looks good (see minor note below for a tweak in the one .md file).
While testing the bidAdapter's native support, I received a 400 Bad Request response from the adserver. I used the sample bid params from the PR description with the mediaTypes object taken from the .md file.
I copied the request and response objects below. Can you take a look?
Request
{"id":"8d6ce1a2-a943-49c2-8adc-b42550ff96f3","imp":[{"id":"218cefd050fb1f","tagid":"/19968336/prebid_native_example_1","secure":false,"native":"{\"assets\":[{\"id\":\"title_0\",\"required\":true,\"title\":{\"len\":140}},{\"id\":\"body_1\",\"required\":true,\"data\":{\"type\":2}}]}"}],"site":{"id":"blank","domain":"test.localhost","page":"http://test.localhost/integrationExamples/gpt/undefined"},"device":{"ip":"peer","ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36","js":1,"language":"en"}}
Response
{
"id": "8d6ce1a2-a943-49c2-8adc-b42550ff96f3",
"bidid": "179055385-1345-18974-0",
"seatbid": [],
"nbr": 2,
"ext": {
"error": "Empty RTB Impression Object"
}
}
The banner test went fine, so just need to figure out the native test.
Thanks!
|
@jsnellbaker Thanks for the review! I have made the changes to the .md examples you requested as well fixed the native request issue with the bid adapter. |
jsnellbaker
left a comment
There was a problem hiding this comment.
@htang555 Thanks for making the updates. The native test is working now.
Type of change
Description of change
Adding Datablocks Bidder and Analytics Adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information
henry@datablocks.net