New option to Include deal KVPs when enableSendAllBids === false#4136
Merged
New option to Include deal KVPs when enableSendAllBids === false#4136
Conversation
enableSendAllBids === false
bretg
suggested changes
Sep 3, 2019
| hb_bidder: 'rubicon', | ||
| foobar: '300x250', | ||
| hb_deal_appnexus: '1234', | ||
| hb_pb_appnexus: '0.53', |
Contributor
There was a problem hiding this comment.
why isn't this 0.1 to match bid4.cpm? Also, I would find it less confusing to use different deal IDs for RP and APN
Collaborator
Author
There was a problem hiding this comment.
Good catch. Let me fix
| hb_adid_appnexus: '148018fe5e', | ||
| hb_bidder_appnexus: 'appnexus', | ||
| }; | ||
| let targetingWithoutAdnxsDeal = { |
Contributor
There was a problem hiding this comment.
I'd also like to see a scenario where the winning bid isn't a deal.
Collaborator
Author
There was a problem hiding this comment.
Ok Will do!
Collaborator
Author
|
@bretg Updated the tests |
jsnellbaker
approved these changes
Sep 5, 2019
jsnellbaker
added
the
needs 2nd review
bretg
approved these changes
Sep 8, 2019
harpere
added
LGTM
and removed
needs 2nd review
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fix for #3899
New option in
targetingControlsto allow sending through bids which have dealId's even when enableSendAllBids is falsealwaysIncludeDealsmust be explicitly set = true to utilize.This code only happens when
enableSendAllBidsisfalse(as if true should have been added anyways!)