Finteza Analytics Adapter: fix cookies#4292
Merged
bretg merged 7 commits intoprebid:masterfrom Oct 15, 2019
Merged
Conversation
bretg
suggested changes
Oct 14, 2019
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Unit tests please. Also, does your Prebid.org doc entry need to mention this cookie, or do you have that covered in your product documentation?
Contributor
Author
Yes, of course. We have covered it on official website: https://www.finteza.com/en/cookies |
Contributor
Author
Fixed. |
bretg
approved these changes
Oct 15, 2019
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reading and sending cookies in analytics requests
Type of change