Skip to content

RhythmOne Adapter - schain support#4414

Merged
sumit116 merged 1 commit intomasterfrom
unknown repository
Nov 18, 2019
Merged

RhythmOne Adapter - schain support#4414
sumit116 merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Nov 1, 2019

Type of change

  • [ x] Feature

Description of change

schain support

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the adapter on hello_world page. The schain object is getting added to the bid request object.

Hi @rhythmonebhaines , Can you add a docs PR to update the .md file of your adapter with schain_supported set to true and add the PR link here?

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs docs PR.

@ghost
Copy link
Author

ghost commented Nov 15, 2019

Doc PR: prebid/prebid.github.io#1608

@sumit116 sumit116 added LGTM and removed needs docs labels Nov 18, 2019
@sumit116 sumit116 merged commit d7ff0e0 into prebid:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments