Skip to content

Request to add new bidder#4545

Merged
Fawke merged 5 commits intoprebid:masterfrom
envivoBidder:master
Dec 20, 2019
Merged

Request to add new bidder#4545
Fawke merged 5 commits intoprebid:masterfrom
envivoBidder:master

Conversation

@envivoBidder
Copy link
Contributor

@envivoBidder envivoBidder commented Dec 6, 2019

envivoBidder is the new adapter we want to integrate with prebid.js

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

envivoBidder is the new adapter we want to integrate with prebid.js

const SUPPORTED_AD_TYPES = [BANNER, VIDEO];
const BIDDER_CODE = 'envivo';
const DOMAIN = 'http://ad.nvivo.tv/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're deprecating the use of http with the prebid-3.0 release. We recommend you change this to https to be part of the new prebid-3.0 release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, we have changed from http to https.

@Fawke
Copy link
Contributor

Fawke commented Dec 10, 2019

@envivoBidder Hi, can you please update the docs on this repo? https://github.com/prebid/prebid.github.io

@Fawke
Copy link
Contributor

Fawke commented Dec 12, 2019

@envivoBidder I was trying to test the video (instream) mediaType with the test params you provided in the md file. I'm getting a CORS error when I do so.
Screenshot 2019-12-11 at 7 40 57 PM

Can you make some changes at your server to resolve this? Thanks.

@Fawke Fawke merged commit 39a57ba into prebid:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments