Somo prebid 3.0 updates#4595
Conversation
Updating fork from upstream
|
Failing test does not appear to be due to our code. |
|
Hi @travisbeale It seems that some of the errors in the browserstack results look to be tied to the somoBidAdapter tests (specifically in IE11). They appear to be failing when the tests are trying to validate the value in the I think this potentially may be due to the slightly malformed mock URLs used in the These URLs only have 1 |
jsnellbaker
left a comment
There was a problem hiding this comment.
The rest of the files/updates appear to be fine. Just need to address the test failures in IE11 (see comment above).
|
@jsnellbaker Fixed the test, thanks for catching that. |
|
@travisbeale It seems that the error are still happening per the latest browserstack test (here). Could you check around some more to see what may be the issue in IE11? |
…RL API isn't supported (IE11)
|
@jsnellbaker The CircleCI tests are now passing for our bid adapter in IE11. The remaining CircleCI test failures do not appear to be in our code. |
jsnellbaker
left a comment
There was a problem hiding this comment.
@travisbeale
Thanks for making the additional updates. I ran another set of the browserstack tests locally and they passed successfully.
Type of change
Description of change
Adding back Somo Audience Prebid adapter with 3.0 compliance.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information