Merged
Conversation
Only attempt to build a bid response if we have the information of which bid to respond to.
Now stubbing adLoader instead of spying. Additional changes to ensure all tests still passed.
Prevent AdButler TypeErrors and pass bid request object into the bid response.
Add optional domain parameter to AdButler adapter.
# Conflicts: # src/adapters/adbutler.js # test/spec/adapters/adbutler_spec.js
Collaborator
|
@mkendall07 LGTM - not sure who to assign to for the next review? |
GLStephen
added
needs 2nd review
Contributor
|
@GLStephen |
sa1omon
pushed a commit
to CleanMediaNet/Prebid.js
that referenced
this pull request
Dec 19, 2019
* Adding AdButler Adapter * Prevent AdButler TypeError Only attempt to build a bid response if we have the information of which bid to respond to. * Refactor AdButler Testing Now stubbing adLoader instead of spying. Additional changes to ensure all tests still passed. * Prevent AdButler TypeErrors Prevent AdButler TypeErrors and pass bid request object into the bid response. * Add optional domain parameter. Add optional domain parameter to AdButler adapter. * Update AdButler adapter to 3.0 spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Re-submitting the AdButler Bid Adapter to meet the Prebid 3.0 requirements