Fidelity Media Bid Adapter. Prebid.js v3 support, CCPA support.#4630
Merged
jsnellbaker merged 10 commits intoprebid:masterfrom Dec 18, 2019
onaydenov:master
Merged
Fidelity Media Bid Adapter. Prebid.js v3 support, CCPA support.#4630jsnellbaker merged 10 commits intoprebid:masterfrom onaydenov:master
jsnellbaker merged 10 commits intoprebid:masterfrom
onaydenov:master
Conversation
Add Prebid.js v.3 support. Add CCPA support.
Add Prebid.js v.3 support. Add CCPA support.
Contributor
Author
|
@mkendall07 the build goes well locally but here we see errors. Could you please look into. |
jsnellbaker
approved these changes
Dec 18, 2019
Collaborator
jsnellbaker
left a comment
There was a problem hiding this comment.
Hi @onaydenov
These changes LGTM.
I would also recommend though to submit the CCPA changes to the 2.44.x-legacy branch, so your adapter there can be compliant for anyone still running 2.x versions of Prebid.js. You will have to open a separate PR to make that update.
sa1omon
pushed a commit
to CleanMediaNet/Prebid.js
that referenced
this pull request
Dec 19, 2019
…id#4630) * Fidelity Media bid adapter update. Add Prebid.js v.3 support. Add CCPA support. * Fidelity Media bid adapter update. Add Prebid.js v.3 support. Add CCPA support. * PR Error fix * error fix * PR Error fix * PR Error fix * PR Error fix * pr error fix * Auction timeout removed * Fix. Timeout is back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fidelity Media Bid Adapter Update.
Add Prebid.js v.3 support.
Add CCPA support.
Other information
PR for the docs: prebid/prebid.github.io#1707