update/fix cases of undefined variables#4661
Merged
jsnellbaker merged 1 commit intomasterfrom Dec 20, 2019
Merged
Conversation
mkendall07
added
the
needs 2nd review
robertrmartinez
approved these changes
Dec 20, 2019
Collaborator
robertrmartinez
left a comment
robertrmartinez
left a comment
There was a problem hiding this comment.
looks good thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
With the latest release (3.1.0), we received a report of an undefined error being thrown from the build file used on the prebid.org example pages. When digging further, found that particular error was introduced through this PR #4620 (at this line).
When investigating why this wasn't caught by the lint check, discovered that this undefined rule was disabled (due to #1111). I have re-enabled this rule and made updates to various files in the project that had (like the case above) a legitimate issue in their code.
There were a number of other cases where files were referring to an object on the page. I have added disable comments in these areas as I think they're intended.