Updating the audience network adapter to be 3.x compliant#4769
Merged
Conversation
Contributor
|
@lovell - we'd like you to have a chance to review and approve this PR. Thanks. |
bretg
approved these changes
Jan 22, 2020
Contributor
bretg
left a comment
There was a problem hiding this comment.
Thanks for providing the gist with the diffs.
Emptymu
approved these changes
Jan 22, 2020
Collaborator
Author
|
I tested the 2.x Request: 3.x Request: |
Contributor
|
Going ahead to merge this as many are waiting on it. The testing done looks reasonable to me. @lovell , we'd still invite you to review the change. |
Contributor
|
Thanks for restoring this adapter. There's a new version coming along soon but this will provide a stopgap for those wanting to use it with Prebid.js v3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding back the audience network adapter and updating it to be compliant on 3.x.
You can see a diff from the 2.x and 3.x versions at the revision history of this GIST:
https://gist.github.com/robertrmartinez/cc4cc72fd1445f0096775aac36305583/revisions