Add new bid adapter for ConnectAd#4806
Merged
idettman merged 7 commits intoprebid:masterfrom Apr 10, 2020
rtuschkany:master
Merged
Add new bid adapter for ConnectAd#4806idettman merged 7 commits intoprebid:masterfrom rtuschkany:master
idettman merged 7 commits intoprebid:masterfrom
rtuschkany:master
Conversation
|
This pull request introduces 1 alert when merging 1894e61 into 613b99b - view on LGTM.com new alerts:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
idettman
reviewed
Mar 6, 2020
idettman
suggested changes
Mar 6, 2020
Contributor
idettman
left a comment
idettman
left a comment
There was a problem hiding this comment.
Please update all the imports to include the '.js' extension
Contributor
Author
|
@idettman @mike-chowla thanks for reviewing! I've fixed all imports. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
@mike-chowla hi mike! just a quick reminder as I've received a stale message. Thx! |
Contributor
Author
|
@mike-chowla @idettman hey guys! Any update on this? We are already waiting for two months to get this approved. Thx! |
idettman
approved these changes
Apr 10, 2020
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Apr 16, 2020
* 'master' of https://github.com/prebid/Prebid.js: (102 commits) Marsmedia - Add vastXml and fix id response (prebid#5067) PubMatic adapter to support image sync (prebid#5104) minor consentManagement fix (prebid#5050) fix circle ci failing tests (prebid#5113) Add Relaido Adapter (prebid#5101) Add new bid adapter for ConnectAd (prebid#4806) change payload (prebid#5105) Utils updates (prebid#5092) Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086) Criteo : added first party data mapping to bidder request (prebid#4954) updateAdGenerationManual (prebid#5032) New bid adapter: Wipes (prebid#5051) Prebid manager analytics utm tags (prebid#4998) CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075) isSafariBrowser update (prebid#5077) Support min &max duration for onevideo (prebid#5079) increment pre version Prebid 3.15.0 release prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064) Prebid adapter for windtalker (prebid#5040) ...
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* Add new bid adapter for ConnectAd * Add new bid adapter for ConnectAd * Conditional fix * js.fix * js-fix * EOF-fix * EOF-Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New Adapter for ConnectAd (formerly ServerBid Alias)
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Add new bid adapter for ConnectAd (formerly ServerBid Alias) prebid.github.io#1785
Other information
ConnectAd is currently a bidder-alias of the ServerBid Adapter. As the ServerBid-Adapter is not maintained anymore, please add our new ConnectAd Adapter.