Fix failing code-coverage command

[Fawke]

Type of change

• Other (Fix for gulp code coverage command)

Description of change

Commandsgulp test-coverage -> gulp view-coverage are not generating code coverage reports after updating npm packages.

The fix is to replace module karma-coverage-istanbul-reporter with karma-coverage.

[lgtm-com]

This pull request introduces 1 alert when merging 222ecdf into ac0ce27 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[jsnellbaker]

Hi @Fawke

Thanks for putting this together. It successfullly resolved the coverage issues I was experiencing recently when I updated my packages. I did have a question though, please see below when you have the chance.

Thanks.

[jsnellbaker]

As a question, I noticed with this block of code added here (and potentially at the reporters variable above), we now seem to always create this coverage directory (such as when we run gulp serve). Is this intended and needed? Or can we alter the code some-what to only generate these folders and files when the test-coverage command is ran?

[Fawke]

@jsnellbaker Thanks for the feedback. That was a good catch, I shouldn't have gotten rid of if(codeCoverage) in function setReporters. I've added it back, and now it only generates coverage folder when we run the command, gulp test-coverage

[robertrmartinez]

Works again thanks,

I do agree with @jsnellbaker if we can suppress the coverage dir when it is not asked for that would be nice.

[jsnellbaker]

Hi @Fawke

Thanks for resyncing the branch with master. It seems like there is one last thing to address.

When I tried to run the gulp coveralls command, I encountered an error:

[13:45:26] Starting 'coveralls'...
cat: build/coverage/lcov.info: No such file or directory
[error] "2020-03-09T17:45:26.550Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2020-03-09T17:45:26.552Z"  'input: ' ''
[error] "2020-03-09T17:45:26.553Z"  'error from convertLcovToCoveralls'

/Users/jsnellbaker/git/Prebid.js/node_modules/coveralls/bin/coveralls.js:19
      throw err;
      ^
Failed to parse string
[13:45:26] 'coveralls' errored after 456 ms
[13:45:26] Error in plugin 'gulp-shell'
Message:
    Command `cat build/coverage/lcov.info | node_modules/coveralls/bin/coveralls.js` failed with exit code 1
Details:
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false
[13:45:26] 'coveralls' errored after 1.18 min

Judging from the cat command, this new setup is not generating the output in a lcov.info file for coveralls to import.

I think if we update the reporter in the karma.conf to use lcov instead of html and update the paths in the gulp coveralls and gulp view-coverage commands, it should work. Can you give this a try?

[Fawke]

Hi @jsnellbaker,

I did as you said, I changed the type to lcov from html and also changed the paths in gulpfile.js. But after doing that, I'm not getting the error you're getting, but a different error.

I read the read the RELEASE_SHEDULE.md file and found that you've to have a username and key to run this job. Since I don't have it, do you think that because of that I'm getting this error?

[jsnellbaker]

To note - we addressed permissions issue separately. This all appears to be working as expected now.