Closed
Conversation
|
This pull request introduces 1 alert when merging 61b37d9 into fc770a3 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 0e4ca6f into ae1fe8f - view on LGTM.com new alerts:
|
Contributor
Author
|
@harpere Here are the docs prebid/prebid.github.io#1788 |
idettman
suggested changes
Mar 6, 2020
Contributor
Author
|
@idettman Fixed the LGTM issue, docs are posted above and the build test failure is on another adapter. Anything else you need? |
Contributor
Author
|
@idettman Can you please let me know what else is needed for this to be accepted. I fixed the LGTM issue. |
degroat
commented
Mar 23, 2020
Contributor
Author
degroat
left a comment
There was a problem hiding this comment.
Requested changes have been completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Prebid adapter for Windtalker.
PR Docs: prebid/prebid.github.io#1788