Skip to content

Prebid adapter for windtalker#4935

Closed
degroat wants to merge 5 commits intoprebid:masterfrom
degroat:master
Closed

Prebid adapter for windtalker#4935
degroat wants to merge 5 commits intoprebid:masterfrom
degroat:master

Conversation

@degroat
Copy link
Contributor

@degroat degroat commented Mar 5, 2020

Type of change

  • [ X] New bidder adapter

Description of change

Prebid adapter for Windtalker.

  • test parameters for validating bids
{
  bidder: 'windtalker',
  params: {
           "pubId":"187046"
           ,"siteId":"10"
           ,"size":"300x250"
           ,"placementId":"456"
  }
}
  • contact email of the adapter’s maintainer: corbin@windtalker.io
  • [X ] official adapter submission

PR Docs: prebid/prebid.github.io#1788

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2020

This pull request introduces 1 alert when merging 61b37d9 into fc770a3 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2020

This pull request introduces 1 alert when merging 0e4ca6f into ae1fe8f - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@degroat
Copy link
Contributor Author

degroat commented Mar 6, 2020

@harpere Here are the docs prebid/prebid.github.io#1788

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update branch to resolve the LGTM errors

@idettman idettman changed the title Prebid adatper for windtalker Prebid adapter for windtalker Mar 6, 2020
@idettman idettman added the docs label Mar 6, 2020
@degroat
Copy link
Contributor Author

degroat commented Mar 10, 2020

@idettman Fixed the LGTM issue, docs are posted above and the build test failure is on another adapter. Anything else you need?

@degroat degroat requested a review from idettman March 13, 2020 01:40
@degroat
Copy link
Contributor Author

degroat commented Mar 17, 2020

@idettman Can you please let me know what else is needed for this to be accepted. I fixed the LGTM issue.

Copy link
Contributor Author

@degroat degroat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes have been completed

@degroat degroat closed this Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments