fix payload#5089
Closed
vincentproxistore wants to merge 3 commits intoprebid:masterfrom
vincentproxistore:master
Closed
fix payload#5089vincentproxistore wants to merge 3 commits intoprebid:masterfrom vincentproxistore:master
vincentproxistore wants to merge 3 commits intoprebid:masterfrom
vincentproxistore:master
Conversation
sumit116
suggested changes
Apr 8, 2020
Contributor
sumit116
left a comment
sumit116
left a comment
There was a problem hiding this comment.
Hi @vincentproxistore, Can you remove the package-lock.json change from this PR?
Contributor
|
@vincentproxistore , there are still some changes in package-lock.json, can you remove the file from the PR? |
Contributor
|
@vincentproxistore, you may need to raise a different PR if the file is not getting removed. In that case you would need to close this one. Also I can see one more PR - #4972 with similar changes, can you close that one as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fix the payload and change endpoint's url
vincent.descamps@proxistore.com