Submitting Tercept Analytics Adapter#5099
Conversation
|
Hi @msm0504 |
|
@mohdusmanalvi I'm not sure exactly. I'll try rerunning the tests. Also, can you merge the latest |
|
@msm0504 The prebid:master is up to date in my fork. |
|
@msm0504 I was also wondering, if you could please let me know, what is the usual timeline for a new analytics adapter to get merged into the main repo? Thanks a lot in advance. |
|
@mohdusmanalvi I'm reviewing this today |
…ata.auctionInit is assignment location params (from review requested changes)
|
@mohdusmanalvi I've approved and merged this PR. This new analytics adapter will be released in Prebid.js version 3.17.0 |
|
@msm0504 Thank you very much! May I ask, whats the timline for v 3.17.0 release? |
|
@msm0504 and @mohdusmanalvi I believe it's this PR that is causing lint failures. for example: https://circleci.com/gh/prebid/Prebid.js/7593?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
|
I also see the same error @harpere has , can we fix it? |
* 'master' of https://github.com/prebid/Prebid.js: Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145) New LuponMedia Bid Adapter (prebid#5120) Feature/send publisher domain (prebid#5121) update test adunit params (prebid#5135) add parameter to the conversant adapter to override the url (prebid#5133) Replace call to old url module with call to utils (prebid#5136) GumGum: uses encodeURIComponent inline (prebid#5124) User ID's (liveramp, britepool) and gdpr (prebid#5114) fix wipes adapter response (prebid#5134) Submitting Tercept Analytics Adapter (prebid#5099) hotfix - undefined consent (prebid#5127) parrableIdSystem: Send current page location to back-end (prebid#5123) Increment pre version Prebid 3.16.0 Release Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039) Update appnexusBidAdapter.js (prebid#4893) Quantcast: Block bids without purpose 1 consent (prebid#5046) ShowHeroes adapter v2 (prebid#5085) Qc/qc usersyncs (prebid#4923)
* master: Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145) New LuponMedia Bid Adapter (prebid#5120) Feature/send publisher domain (prebid#5121) update test adunit params (prebid#5135) add parameter to the conversant adapter to override the url (prebid#5133) Replace call to old url module with call to utils (prebid#5136) GumGum: uses encodeURIComponent inline (prebid#5124) User ID's (liveramp, britepool) and gdpr (prebid#5114) fix wipes adapter response (prebid#5134) Submitting Tercept Analytics Adapter (prebid#5099) hotfix - undefined consent (prebid#5127) parrableIdSystem: Send current page location to back-end (prebid#5123) Increment pre version Prebid 3.16.0 Release Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039) Update appnexusBidAdapter.js (prebid#4893) Quantcast: Block bids without purpose 1 consent (prebid#5046) ShowHeroes adapter v2 (prebid#5085) Qc/qc usersyncs (prebid#4923)
* files for Tercept Analytics Adapter and corresponding markdown and unit test file * replaced all == with ===, removed redundant else if and changed how data.auctionInit is assignment location params (from review requested changes) Co-authored-by: MohdUsmanAlvi <usman.alvi@tercept.com>
…it test file
terceptAnalyticsAdapter_spec.js
Type of change
Description of change
Adding a new Analytics Adapter.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information