Skip to content

Improve tcf2 support#5138

Merged
musikele merged 3 commits intoprebid:masterfrom
criteo-forks:tcf2supp
Apr 24, 2020
Merged

Improve tcf2 support#5138
musikele merged 3 commits intoprebid:masterfrom
criteo-forks:tcf2supp

Conversation

@bmwcmw
Copy link
Collaborator

@bmwcmw bmwcmw commented Apr 17, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

To better support the TCF2 specs and the consent decoding, we need to

  • Append the iab version to the request
  • Remove an incomplete translation of given consent parameter

@bmwcmw bmwcmw changed the title Enforce tcf2 support Enhance tcf2 support Apr 23, 2020
@bmwcmw bmwcmw changed the title Enhance tcf2 support Improve tcf2 support Apr 23, 2020
@mkendall07 mkendall07 requested a review from musikele April 23, 2020 20:22
Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musikele musikele merged commit e09a2c3 into prebid:master Apr 24, 2020
@bmwcmw bmwcmw deleted the tcf2supp branch May 12, 2020 08:23
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* Fetch gdpr api version from provided consent object

* Remove consentGiven boolean

* Bump version to 29 and remove unused const

Co-authored-by: mi.chen <mi.chen@criteo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments