SublimeBidAdapter src/url.js import fix#5150
Merged
robertrmartinez merged 44 commits intoprebid:masterfrom Apr 21, 2020
Merged
Conversation
robertrmartinez
approved these changes
Apr 21, 2020
Collaborator
robertrmartinez
left a comment
robertrmartinez
left a comment
There was a problem hiding this comment.
Good catch.
I missed this in my review. Sorry about that.
Need to remind myself importing url is not allowed.
Contributor
Author
|
Thank you @robertrmartinez for approving, |
Contributor
Author
|
Got it, colossussspBidAdapter_spec uses |
Contributor
Author
|
Thanks, @robertrmartinez ! |
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * avoid using src/url.js * avoid using for..of
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
SublimeBidAdapter was using src/url.js import which is deprecated, hence braking tests.
Fixing it here.