Skip to content

README Note about what Node version works#5159

Closed
harpere wants to merge 1 commit intomasterfrom
readme-node-version
Closed

README Note about what Node version works#5159
harpere wants to merge 1 commit intomasterfrom
readme-node-version

Conversation

@harpere
Copy link
Collaborator

@harpere harpere commented Apr 23, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • [ x] Other

Description of change

have heard of several dev having trouble with more recent versions of Node, so updated the Readme with a note about a particular version that works.

@harpere harpere requested a review from jsnellbaker April 23, 2020 15:53
@harpere harpere added needs 2nd review Core module updates require two approvals from the core team needs review and removed needs 2nd review Core module updates require two approvals from the core team labels Apr 23, 2020
@robertrmartinez
Copy link
Collaborator

robertrmartinez commented Apr 23, 2020

Hi!

@Fawke has made a PR which is meant to fix gulp test-coverage, but it seems it will also solve our incompatibility with node 12.X versions!

#5128

@stale
Copy link

stale bot commented May 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 7, 2020
@stale stale bot closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments