Merged
Conversation
Updating how pbsBidAdapter sets the "TTL" for bids. TTL in PBJS terms is how long the bid can stay in cache. However, the OpenRTB standard location for this value is `exp`.
robertrmartinez
approved these changes
Sep 8, 2020
| const configTtl = _s2sConfig.defaultTtl || DEFAULT_S2S_TTL; | ||
| bidObject.ttl = (bid.ttl) ? bid.ttl : configTtl; | ||
| // the OpenRTB location for "TTL" as understood by Prebid.js is "exp" (expiration). | ||
| bidObject.ttl = (bid.exp) ? bid.exp : configTtl; |
Collaborator
There was a problem hiding this comment.
This works.
Although I would just do
bidObject.ttl = bid.exp || configTtl;But maybe I am not thinking of some use case as the previous code was doing the same thing.
Collaborator
|
@smenzer this looks like it has two reviewers and it is assigned to me. What's the purpose of that? |
Collaborator
|
Sorry @GLStephen i didn't notice the second reviewer. Will remove you. |
mkendall07
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updating how pbsBidAdapter sets the "TTL" for bids.
TTL in PBJS terms is how long the bid can stay in cache. However, the OpenRTB standard location for this value is
exp.Related to prebid/prebid-server#1386