Conversation
jsnellbaker
approved these changes
Sep 15, 2020
Collaborator
jsnellbaker
left a comment
jsnellbaker
left a comment
There was a problem hiding this comment.
I think this is okay.
@mkendall07 tagging you for 2nd review (in case we should double-check anything with the circleci support).
jsnellbaker
added
needs 2nd review
mkendall07
approved these changes
Sep 16, 2020
Contributor
mkendall07
left a comment
mkendall07
left a comment
There was a problem hiding this comment.
LGTM - we have a ton of circleCI credits so this should be fine.
zandree-owneriq
added a commit
to inmar/oiq_Prebid.js
that referenced
this pull request
Sep 16, 2020
This reverts commit bce32dc.
zandree-owneriq
added a commit
to inmar/oiq_Prebid.js
that referenced
this pull request
Sep 30, 2020
This reverts commit eb11958.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We were using less resource on our circle ci container (2 cpus and 4GB RAM). I have upgraded it to use (8cpu and 16GB RAM). The pipeline is executing a little bit faster now.
Here's a comparison:
Before:
After:
Since the tests run on Browserstack, the timings are also limited by the resource we've available there, and if two or more Circle CI jobs are running in parallel, the tests will timeout or take longer than usual. That explains one test running ~ 16m even after the upgrade.
NOTE:
This PR does not have any effect on the tests that are currently failing intermittently.