Skip to content

schain complete 0 omitted from yield request#5890

Closed
IDRATHERDANCE wants to merge 6 commits intoprebid:masterfrom
IDRATHERDANCE:schain.version-can-be-0
Closed

schain complete 0 omitted from yield request#5890
IDRATHERDANCE wants to merge 6 commits intoprebid:masterfrom
IDRATHERDANCE:schain.version-can-be-0

Conversation

@IDRATHERDANCE
Copy link
Contributor

@IDRATHERDANCE IDRATHERDANCE commented Oct 23, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

if schain complete equals 0 it was omitted from yield request. That is a bug. According to the standards described here: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md. Complete can be 0 or 1. This is a simple fix.

  • test parameters for validating bids
{
  bidder: 'yieldlab',
  params: {
    schain
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@IDRATHERDANCE IDRATHERDANCE changed the title fix: schain version 0 omitted from yield request schain version 0 omitted from yield request Oct 23, 2020
@IDRATHERDANCE IDRATHERDANCE changed the title schain version 0 omitted from yield request schain complete 0 omitted from yield request Oct 27, 2020
@smenzer
Copy link
Collaborator

smenzer commented Oct 27, 2020

please remove package-lock.json from this PR before we can merge, thanks!

@smenzer smenzer self-assigned this Oct 27, 2020
@smenzer
Copy link
Collaborator

smenzer commented Oct 27, 2020

you don't want to delete the package-lock.json file, we need that in the repository...you just need to remove it from the PR...if it's easier you can create a new PR that does not include the file in any commit.

@IDRATHERDANCE
Copy link
Contributor Author

sure, thanks. i will create a new pr and close this one

@IDRATHERDANCE
Copy link
Contributor Author

#5902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments