Unruly Bid Adapter: consolidated adapter with RhythmOne

[opeledtremor]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

This is a consolidated adapter between the Unruly adapter and the RhythmOne Adapter.
now the unruly adapter support instream, outstream and banner.
list of changes:

• change to request format to support the new endpoint + support multiple requests.
• added support to handle banner/instream/outstream bid response.
• updated the bid validations.
• removed the user syncing from client since now it is handled on the backend side.
• added support for the bidFloor module.
• added relevant unit tests.

• test parameters for validating bids:

[
          {
            "code": "video2",
            "mediaTypes": {
              "video": {
                "context": "outstream",
                "mimes": [
                "video/mp4"
                 ],
                "playerSize": [
                  [
                    640,
                    480
                  ]
                ]
              }
            },
            "bids": [
              {
                "bidder": "unruly",
                "params": {
                  "siteId": 212337,
                  "featureOverrides": {
                        "canRunUnmissable": true
                    }
                }
              }
            ]
          },
          {
            "code": "banner1",
            "mediaTypes": {
              "banner": {
                "sizes": [
                  [300, 250]
                ]
              }
            },
            "bids": [
              {
                "bidder": "unruly",
                "params": {
                  "siteId": 233261
                }
              }
            ]
          },
          {
            "code": "video1",
            "mediaTypes": {
              "video": {
                "context": "instream",
                "mimes": [
                  "video/mp4"
                ],
                "playerSize": [
                  [
                    640,
                    480
                  ]
                ]
              }
            },
            "bids": [
              {
                "bidder": "unruly",
                "params": {
                  "siteId": 233261
                }
              }
            ]
          }
        ]

• contact email of the adapter’s maintainer: opeled@tremorvideo.com

• official adapter submission

• A link to a PR on the docs repo: Unruly r1 consolidated adapter prebid.github.io#3054

[Fawke]

Hi @opeledtremor, looks good overall, just a couple things you can take a look at.

[Fawke]

Please hardcode to https://

[tallavon]

Pushed the requested change (adding https to the endpoint).

[Fawke]

I am all for using the object spread syntax but just letting you know it won't work in IE11.

[Fawke]

Looks like it does get transpiled to es5, so I guess, it's fine.