Adyoulike bidder - Video playerSize format#7227
Merged
ChrisHuie merged 22 commits intoprebid:masterfrom Jul 28, 2021
Merged
Conversation
ChrisHuie
approved these changes
Jul 28, 2021
Contributor
Author
|
@ChrisHuie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Minor improvement.
make sure the video size format is consistent.
Description of change
The player size is sent with Array of array's like multiple size are needed even if only one size is necessary.
This improvement makes sure this behavior won't change and break our ad server video response.
contact email of the adapter’s maintainer
guillaume.andouard@adyoulike.com
[*] official adapter submission
please see:
https://github.com/prebid/Prebid.js/issues/7217e