gptPreAuction Module: update to include MCM support#7242
Merged
Conversation
ChrisHuie
approved these changes
Aug 2, 2021
Collaborator
|
@mmoschovas does a unit test need to be added for when MCM is enabled or is that already covered by the current testing? |
Contributor
Author
|
@ChrisHuie yes let me add a test in now. Hold off on merging until this is updated |
added 2 commits
August 2, 2021 13:49
Contributor
Author
|
@ChrisHuie test have been added |
ChrisHuie
approved these changes
Aug 2, 2021
Collaborator
|
very happy this merged but just a reminder 2nd reviewer required on non-vendor specific modules as well |
Contributor
|
FWIW - this was missing the doc update. Fixed in prebid/prebid.github.io#3206 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The gptPreAuction module is not be compatible with the approach/format that Google uses for MCM (Multiple Customer Management). This update addresses the underlying issue by trimming the child ID from the ad unit name.
Ad Slot Definition:
/123456,7654321/Ad_Unit_Name/1234567890This is currently being passed via FPD as is under imp[].ext.data.pbadslot/adserver.adslot. SSPs will have issues reading this value due to the comma separated IDs.
Trimmed Name for FPD:
/123456/Ad_Unit_Name/1234567890This update also includes a config enablement via