Skip to content

BLIINK Bidder: Add new adapter#7297

Closed
joibor wants to merge 17 commits intoprebid:masterfrom
joibor:master
Closed

BLIINK Bidder: Add new adapter#7297
joibor wants to merge 17 commits intoprebid:masterfrom
joibor:master

Conversation

@joibor
Copy link
Contributor

@joibor joibor commented Aug 12, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added BLIINK Bidder Adapter

  • test parameters for validating bids
{
  bidder: 'bliink',
  params: {
    tagId: 32,
    placement: 'video'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2021

This pull request introduces 2 alerts when merging 2aa6065 into 3b59a2b - view on LGTM.com

new alerts:

  • 1 for Identical operands
  • 1 for Useless conditional

@ChrisHuie
Copy link
Collaborator

Kicked off the circleci tests for this pr

let request = server.requests[1];
expect(request.url).to.be.eq('https://idx.liadm.com/idex/prebid/89899');
expect(request.url).to.be.eq('https://rp.liadm.com/j?wpn=prebid&pu=http%3A%2F%2Flocalhost%3A9876%2F%3Fid%3D70114353&se=e30&e=58131bc547fb87af94cebdaf3102321f&dtstmp=1627484401289');
// expect(request.url).to.be.eq('https://idx.liadm.com/idex/prebid/89899');
Copy link
Collaborator

@ChrisHuie ChrisHuie Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe you meant to change this? This test seems to be currently failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, yes exactly, I apply a fix, thanks.

@joibor
Copy link
Contributor Author

joibor commented Aug 13, 2021

Please, if you can close this PR, it is replace by this one : #7299.
Thanks @ChrisHuie

@joibor joibor changed the title BLIINK Bidder: Add new adapter BLIINK Bidder: Add new adapter [DE NOT MERGE] Aug 13, 2021
@joibor joibor changed the title BLIINK Bidder: Add new adapter [DE NOT MERGE] BLIINK Bidder: Add new adapter [DO NOT MERGE] Aug 13, 2021
@joibor joibor changed the title BLIINK Bidder: Add new adapter [DO NOT MERGE] BLIINK Bidder: Add new adapter Aug 13, 2021
@ChrisHuie ChrisHuie closed this Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments