Closed
Conversation
added 8 commits
July 28, 2021 17:16
…s, gdpr, pageUrl), improvement test units
|
This pull request introduces 2 alerts when merging 2aa6065 into 3b59a2b - view on LGTM.com new alerts:
|
Collaborator
|
Kicked off the circleci tests for this pr |
ChrisHuie
reviewed
Aug 12, 2021
| let request = server.requests[1]; | ||
| expect(request.url).to.be.eq('https://idx.liadm.com/idex/prebid/89899'); | ||
| expect(request.url).to.be.eq('https://rp.liadm.com/j?wpn=prebid&pu=http%3A%2F%2Flocalhost%3A9876%2F%3Fid%3D70114353&se=e30&e=58131bc547fb87af94cebdaf3102321f&dtstmp=1627484401289'); | ||
| // expect(request.url).to.be.eq('https://idx.liadm.com/idex/prebid/89899'); |
Collaborator
There was a problem hiding this comment.
I don't believe you meant to change this? This test seems to be currently failing.
Contributor
Author
There was a problem hiding this comment.
Hi, yes exactly, I apply a fix, thanks.
Contributor
Author
|
Please, if you can close this PR, it is replace by this one : #7299. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added BLIINK Bidder Adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information