Adding adKernel adapter by ckbo3hrk · Pull Request #739 · prebid/Prebid.js

ckbo3hrk · 2016-10-24T16:29:18Z

Type of change

New bidder adapter

Description of change

Added AdKernel adapter

test parameters for validating bids

{
  bidder: 'adkernel',
  params: {
    zoneId : '30164',
    host : 'cpm.metaadserving.com'
  }
}

contact email of the adapter’s maintainer: denis@adkernel.com
official adapter submission

Other information

mkendall07

Thanks for the PR. Please address code review comments.

mkendall07 · 2016-11-03T21:23:00Z

src/adapters/adkernel.js

@@ -0,0 +1,194 @@
+var bidmanager = require('../bidmanager.js');


please use ES 6 import syntax here.

mkendall07 · 2016-11-03T21:23:18Z

src/adapters/adkernel.js

+ * Adapter for requesting bids from AdKernel white-label platform
+ * @class
+ */
+var AdkernelAdapter = function AdkernelAdapter() {


prefer const

mkendall07 · 2016-11-03T21:34:06Z

src/adapters/adkernel.js

+    const dispatcher = new RtbRequestDispatcher();
+    //process individual bids
+    utils._each(bids, function (bid) {
+      let size = bid.sizes[0];


Does your adapter support multi size?

No, adapter doesn't support multiple sizes.

mkendall07 · 2016-11-03T21:35:22Z

src/adapters/adkernel.js

+   *  Create bid object for the bid manager
+   */
+  function createBidObject(bidObj, width, height) {
+    return utils.extend(bidfactory.createBid(1), {


Please store a reference to the bid request object and pass it to createBid(1, bidRequest) as this allows us to match the bid.adId to bid response.

mkendall07 · 2016-11-03T21:41:45Z

test/spec/adapters/adkernel_spec.js

+    sizes: [[728, 90]]
+  };
+
+	const bidResponse1 = {


nit: please apply formatting to spec file.

mkendall07 · 2016-11-03T21:52:24Z

src/adapters/adkernel.js

+    //translate adunit info into rtb impression dispatched by host/zone
+    this.addImp = function (host, zone, width, height, bidId, adUnitId) {
+      if (!(host in _dispatch)) {
+        _dispatch[host] = {};


If host is undefined, you should abort this request. Without the host param, I was seeing network requests to http://undefined/....

mkendall07 · 2016-11-03T21:55:21Z

src/adapters/adkernel.js

+
+  function buildRequestParams(zone, rtbReq) {
+    return {
+      'zone': zone,


zone should be encoded too if possible.

mkendall07 · 2016-11-10T15:40:02Z

@ckbo3hrk
Any update here?

ckbo3hrk · 2016-11-10T17:13:35Z

@mkendall07
On vacation. Everything will be done on 14th of November.

ckbo3hrk · 2016-11-16T08:54:50Z

@mkendall07
Code review comments has been adressed.

mkendall07 · 2016-11-16T15:19:35Z

src/adapters/adkernel.js

-      _dispatch = {},
+    const _dispatch = {},
+      originalBids = {},
      site = createSite();


Please change to:

const _dispatch = {}; const originalBids = {}; const site = createSite();

mkendall07 · 2016-11-16T15:40:51Z

src/adapters/adkernel.js

@@ -0,0 +1,207 @@
+import bidmanager from "src/bidmanager";


please use single quotes for string literals '

mkendall07

LGTM. Can merge when you make those minor changes I have commented on.

mkendall07 · 2016-11-16T15:41:55Z

@ckbo3hrk if you get this done today, it will be included in the 0.15.0 release.

ckbo3hrk · 2016-11-16T16:37:59Z

@mkendall07
done

mkendall07 · 2016-11-16T20:08:10Z

LGTM. Bids are being received, unit tests pass. Thanks for contributing to Prebid.js

aneuway2 · 2016-11-17T17:28:04Z

@ckbo3hrk are all parameter's required or are there optional inputs?

ckbo3hrk · 2016-11-17T17:55:00Z

@aneuway2
Both parameters are required.

mkendall07 · 2016-11-17T18:09:12Z

@ckbo3hrk
Please submit a docs PR here: https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders

…ebid-0.15.2 to release/1.8.0 * commit '3c3d298eb248a7f69dd4ae86f3f6341f2c04b1b5': (36 commits) CHANGELOG Add new adapters for AOL analytics. Prebid 0.15.2 Release Fix issue with building prebid from npm install. Babel loader was being skipped because of the project residing in /node_modules/ directory. (prebid#820) Increment pre version Prebid 0.15.1 Release Update bidFloor->bidfloor to match other bidders + updated conversant docs (prebid#818) Correct 'bidloor' typo in Conversant adapter (prebid#815) Increment pre version 0.15.0 release support IE userLanguage Navigator property (prebid#807) exclude node_modules from babel-loader as to prevent strict mode errors (prebid#806) PulsePoint Adapter - Support for additional parameters. (prebid#784) Fix 'skippable' targeting typo (prebid#804) Adding adKernel adapter (prebid#739) Babel plugin fixes to make the generated code syntax valid in ie8 (prebid#799) Vertoz Adapter (prebid#789) RubiconLite is now just Rubicon and "rubicon" aliases "rubiconLite" (prebid#783) add version to global namespace (prebid#794) Adform adapter tests fixed prebid#769 (prebid#793) ...

…8.0 to master * commit '997aa5bce17aafd6b215d335551e89757f92bf3e': (37 commits) CHANGELOG. CHANGELOG Add new adapters for AOL analytics. Prebid 0.15.2 Release Fix issue with building prebid from npm install. Babel loader was being skipped because of the project residing in /node_modules/ directory. (prebid#820) Increment pre version Prebid 0.15.1 Release Update bidFloor->bidfloor to match other bidders + updated conversant docs (prebid#818) Correct 'bidloor' typo in Conversant adapter (prebid#815) Increment pre version 0.15.0 release support IE userLanguage Navigator property (prebid#807) exclude node_modules from babel-loader as to prevent strict mode errors (prebid#806) PulsePoint Adapter - Support for additional parameters. (prebid#784) Fix 'skippable' targeting typo (prebid#804) Adding adKernel adapter (prebid#739) Babel plugin fixes to make the generated code syntax valid in ie8 (prebid#799) Vertoz Adapter (prebid#789) RubiconLite is now just Rubicon and "rubicon" aliases "rubiconLite" (prebid#783) add version to global namespace (prebid#794) ...

…_upgrade priceFloors: fix bug where floors are not set when TIDs are disabled …

initial adkernel adapter commit

2da633e

ckbo3hrk changed the title ~~initial adkernel adapter commit~~ Adding adKernel adapter Oct 24, 2016

mkendall07 self-assigned this Oct 24, 2016

mkendall07 modified the milestones: Prebid 0.14.0, Prebid 0.15.0 Oct 31, 2016

mkendall07 suggested changes Nov 3, 2016

View reviewed changes

mkendall07 added the needs update label Nov 3, 2016

mkendall07 modified the milestones: Backlog, Prebid 0.15.0 Nov 4, 2016

minor refactoring

b2cefc1

mkendall07 reviewed Nov 16, 2016

View reviewed changes

mkendall07 suggested changes Nov 16, 2016

View reviewed changes

ckbo3hrk added 2 commits November 16, 2016 17:53

minor changes

a0ba4b2

merge conflict resolved

72facd4

mkendall07 approved these changes Nov 16, 2016

View reviewed changes

mkendall07 closed this Nov 16, 2016

mkendall07 reopened this Nov 16, 2016

mkendall07 merged commit d72dbf4 into prebid:master Nov 16, 2016

pm-abhinav-deshpande pushed a commit to pm-abhinav-deshpande/Prebid.js that referenced this pull request Apr 23, 2025

Merge pull request prebid#739 from PubMatic-OpenWrap/nightly_prebid_8…

50eb8f6

…_upgrade priceFloors: fix bug where floors are not set when TIDs are disabled …

		@@ -0,0 +1,194 @@
		var bidmanager = require('../bidmanager.js');

Conversation

ckbo3hrk commented Oct 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

mkendall07 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Nov 10, 2016

Uh oh!

ckbo3hrk commented Nov 10, 2016

Uh oh!

ckbo3hrk commented Nov 16, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkendall07 left a comment

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Nov 16, 2016

Uh oh!

ckbo3hrk commented Nov 16, 2016

Uh oh!

mkendall07 commented Nov 16, 2016

Uh oh!

aneuway2 commented Nov 17, 2016

Uh oh!

ckbo3hrk commented Nov 17, 2016

Uh oh!

mkendall07 commented Nov 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

ckbo3hrk commented Oct 24, 2016 •

edited

Loading